Subject: Re: Problems with recent vnode changes
To: Antti Kantee <pooka@cs.hut.fi>
From: Julio M. Merino Vidal <jmmv84@gmail.com>
List: current-users
Date: 07/23/2007 17:43:51
On 23/07/2007, at 11:07, Antti Kantee wrote:
>> 2) basic tmpfs (can't see any recent changes really specific to  
>> tmpfs though)
>
> This KASSERT is incorrect, it is legal to rename a directory to  
> another
> if the target directory is empty.
>
>         if (tvp != NULL) {
>                 struct tmpfs_node *tnode;
>
>                 tnode = VP_TO_TMPFS_NODE(tvp);
>
>                 /* The source node cannot be a directory in this  
> case. */
>                 KASSERT(fnode->tn_type != VDIR);
>
> jmmv, could you look at fixing it?  Would be nice-to-have for  
> NetBSD 4.0.

This should be fixed now.  Pullup for 4.0 requested.

Thanks for catching this problem!

-- 
Julio M. Merino Vidal <jmmv84@gmail.com>