Subject: Re: HEADS UP: wide curses code merged to HEAD
To: Brett Lymn <blymn@baesystems.com.au>
From: Bernd Ernesti <netbsd@lists.veego.de>
List: current-users
Date: 05/28/2007 18:24:33
Hi Brett,


On Tue, May 29, 2007 at 12:37:38AM +0930, Brett Lymn wrote:
> 
> Folks,
> 
> I have just merged the wide curses modifications that were originally
> done by Ruibiao Qiu as a Google Summer of Code project.  Both myself
> and Julian Coleman worked on pulling the code up to a recent version
> of our curses and fixing some bugs along the way.  We believe that the
> code is good enough for widespread use.

Thank you very much to all of you who were working on it.

There is a small problem:

#   compile  libcurses/ins_wch.go
cc -O2 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wno-sign-compare -Wno-traditional -Wreturn-type -Wswitch -Wshadow  -Werror  -Wuninitialized -Wstrict-prototypes -Wmissing-prototypes    -I/src/lib/libcurses -I/src/lib/libterm -DCM_N -DCM_GT -DCM_B -DCM_D -DHAVE_WCHAR    -c -DDEBUG    -g /src/lib/libcurses/ins_wch.c -o ins_wch.go
cc1: warnings being treated as errors
/src/lib/libcurses/ins_wch.c: In function 'wins_wch':
/src/lib/libcurses/ins_wch.c:235: warning: declaration of 'x' shadows a previous local
/src/lib/libcurses/ins_wch.c:105: warning: shadowed declaration is here
*** Error code 1

#   compile  libcurses/ins_wstr.go
cc -O2 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wno-sign-compare -Wno-traditional -Wreturn-type -Wswitch -Wshadow  -Werror  -Wuninitialized -Wstrict-prototypes -Wmissing-prototypes    -I/src/lib/libcurses -I/src/lib/libterm -DCM_N -DCM_GT -DCM_B -DCM_D -DHAVE_WCHAR    -c -DDEBUG    -g /src/lib/libcurses/ins_wstr.c -o ins_wstr.go
cc1: warnings being treated as errors
/src/lib/libcurses/ins_wstr.c: In function 'wins_nwstr':
/src/lib/libcurses/ins_wstr.c:184: warning: declaration of 'x' shadows a previous local
/src/lib/libcurses/ins_wstr.c:139: warning: shadowed declaration is here
/src/lib/libcurses/ins_wstr.c:230: warning: declaration of 'x' shadows a previous local
/src/lib/libcurses/ins_wstr.c:139: warning: shadowed declaration is here
/src/lib/libcurses/ins_wstr.c:311: warning: declaration of 'x' shadows a previous local
/src/lib/libcurses/ins_wstr.c:139: warning: shadowed declaration is here

It looks like it would be ok to remove the 'int x;' line in the DEBUG lines.

Bernd