Subject: Re: kdump(1) and non printable ioctl types values
To: None <current-users@netbsd.org>
From: Christos Zoulas <christos@astron.com>
List: current-users
Date: 03/19/2007 15:18:19 
In article <20070319124631.GA151713@medusa.sis.pasteur.fr>,
Nicolas Joly  <njoly@pasteur.fr> wrote:
>-=-=-=-=-=-
>
>
>Hi,
>
>While working on NetBSD/amd64 compat linux/linux32, i noticed that
>kdump(1) display strange characters for non printable ioctl types
>values ...
>
>By example, compat linux use type 0x89 for socket ioctls :
>
> 19042      1 MATLAB   CALL  socket(2,2,0)
> 19042      1 MATLAB   RET   socket 4
> 19042      1 MATLAB   CALL  ioctl(4,_IO('<89>',0x27,0),0x7f7fffffa480)
> 19042      1 MATLAB   RET   ioctl 0
> 19042      1 MATLAB   CALL  close(4)
> 19042      1 MATLAB   RET   close 0
>
>With the attached patch, all non printable characters are displayed
>with their hexadecimal value.
>
> 19042      1 MATLAB   CALL  socket(2,2,0)
> 19042      1 MATLAB   RET   socket 4
> 19042      1 MATLAB   CALL  ioctl(4,_IO(0x89,0x27,0),0x7f7fffffa480)
> 19042      1 MATLAB   RET   ioctl 0
> 19042      1 MATLAB   CALL  close(4)
> 19042      1 MATLAB   RET   close 0
>
>Does it looks ok ?

Looks fine to me!

christos