Subject: Re: cgd failure since hackathon
To: Christian Biere <christianbiere@gmx.de>
From: Quentin Garnier <cube@cubidou.net>
List: current-users
Date: 11/30/2006 20:22:26
--PVGnt3hziMCGXk95
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 30, 2006 at 08:21:09PM +0100, Christian Biere wrote:
> Quentin Garnier wrote:
> > Anyone objects?  The size_t -> ssize_t is necessary to avoid
> > signed/unsigned mismatch, if we ever want to warn on that (I thought we
> > did, though).
>=20
> Why not the smaller fix?

I don't see any good reason not to make ci_blocksize a ssize_t.

OTOH, there should also be a cast when cf_blocksize is affected,
because of the int/ssize_t potential mismatch.

--=20
Quentin Garnier - cube@cubidou.net - cube@NetBSD.org
"You could have made it, spitting out benchmarks
Owe it to yourself not to fail"
Amplifico, Spitting Out Benchmarks, Hometakes Vol. 2, 2005.

--PVGnt3hziMCGXk95
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (NetBSD)

iQEVAwUBRW8vctgoQloHrPnoAQJfLQf+P5B1dYxnuANnK3MgLE/UBt5kK1p4gqZW
0QTPAdcuBW2vlY80jSqXY/yhstu3AMxt76QDuLotOP7kuCpL4DQORMFwvMOlinWy
JpaeMnAt4LK/iyDGWpryo2UldB12dQ1biR4WqIjAed4x+DRYGLAtNoDnlgCdeuFD
H341p0WjITm45emoczFL4hOJ6TLb+STqOXpaNKdzJaumCSic96HNBOvhIwt6ay+a
ML4EI6GyXG5JFoj1fSw5b+KffSQAe1rr/p0FfUy9KPecGU7W1Jm3YW60wlG+zaH8
SAoQqmI0UiWuwaBkI0OjUa0mdNBYgSEH3MMw/+XU5HjshAL4mTIEkQ==
=+HpY
-----END PGP SIGNATURE-----

--PVGnt3hziMCGXk95--