Sure wish I actually READ the patches! Ugh, how embarassing. ;)

Well, at least my drive did work when added that entry.  Let's try the
REAL patch now, heh.

--Blair

On 10/27/06, Blair Sadewitz <blair.sadewitz@gmail.com> wrote:
> I have a VT8237A SATA controller, and brought home a SATA drive today
> to try with those patches.
>
> Unfortunately, it was not included in pciide_via_products[] in
> viaide.c.  See kern/34927.
>
> All I had to do to fix it was this:
>
> --- viaide.c.orig       2006-10-26 23:29:52.000000000 -0400
> +++ viaide.c    2006-10-26 23:29:41.000000000 -0400
> @@ -258,6 +258,11 @@
>           "VIA Technologies VT8237 SATA Controller",
>           via_sata_chip_map,
>         },
> +       { PCI_PRODUCT_VIATECH_VT8237A_SATA,
> +         0,
> +         "VIA Technologies VT8237A SATA Controller",
> +         via_sata_chip_map,
> +       },
>         { PCI_PRODUCT_VIATECH_VT8237R_SATA,
>           0,
>
> Cheers,
>
> --Blair
>
> On 10/26/06, Charlie Root <root@quicky.whooppee.com> wrote:
> > OK, I just updated via CVS (in the last 15 minutes), and got the
> > following results:
> >
> > #      link  TEST/netbsd
> > /usr/src/obj.amd64/tooldir.NetBSD-4.99.3-x86_64/bin/x86_64--netbsd-ld
> > -Map netbsd.map --cref -T /usr/src/sys/arch/amd64/conf/kern.ldscript
> > -Ttext 0xffffffff80100000 -e start -X -o netbsd ${SYSTEM_OBJ}
> > ${EXTRA_OBJ} vers.o
> > viaide.o: In function `via_sata_chip_map':
> > viaide.c:(.text+0x432): undefined reference to `wdc_sataprobe'
> > viaide.o: In function `via_sata_chip_map_new':
> > viaide.c:(.text+0x73e): undefined reference to `wdc_sataprobe'
> > *** [netbsd] Error code 1
> > 1 error
> >
> > nbmake: stopped in /usr/obj/sys/arch/amd64/compile.amd64/TEST
> >
> > ERROR: Failed to make all in
> > /usr/src/sys/arch/amd64/compile/obj.amd64/TEST
> > *** BUILD ABORTED ***
> >
> >
> >
> > On Thu, 26 Oct 2006, Manuel Bouyer wrote:
> >
> > > On Wed, Oct 25, 2006 at 06:08:50PM -0700, paul@whooppee.com wrote:
> > >> Hmmm, must be something missing from the attached diff
> > >> file...
> > >>
> > >> Did you forget to diff one of the header files?
> > >>
> > >> If it matters, this was on port-amd64 current as of
> > >> yesterday...
> > >
> > > It's too old :) I commited these changes just one or two hours before
> > > sending the patch
> > >
> > > --
> > > Manuel Bouyer, LIP6, Universite Paris VI.
> Manuel.Bouyer@lip6.fr
> > >     NetBSD: 26 ans d'experience feront toujours la difference
> > > --
> > >
> >
> > ----------------------------------------------------------------------
> > |   Paul Goyette   | PGP DSS Key fingerprint: |  E-mail addresses:   |
> > | Network Engineer | FA29 0E3B 35AF E8AE 6651 |  paul@whooppee.com   |
> > |                  | 0786 F758 55DE 53BA 7731 | pgoyette@juniper.net |
> > ----------------------------------------------------------------------
> >
>