Subject: Re: bin/3998: Trying to mount a filesystem you don't have is cryptic
To: Peter Seebach <>
From: Christian Hattemer <>
List: current-users
Date: 09/27/2006 17:34:25
Warning: This is a message in MIME format. Your mail reader does not
support MIME. Some parts of this message will be readable as plain text.
To see the rest, you will need to upgrade your mail reader. Following are
some URLs where you can find MIME-capable mail programs for common platforms:

  Amiga............: YAM
  Unix.............: Metamail
  Windows/Macintosh: Eudora

General info about MIME can be found at:

Content-Type: text/plain


attatched is a diff showing where to change the returned errno in our case.

We just need the proper errno to put there now.

I have used EPROTONOSUPPORT in the diff for now, but it shouldn't be kept
since it would again be confusing with the other file systems besides NFS.

I used it because there is already an EOPNOTSUPP and I wanted something
unique for testing. sys/errno.h lists EOPNOTSUPP under "ipc/networking" so
it isn't really appropriate also. It wasn't very clear anyway.

I heard the suggestion "File system support not enabled", so why not add a
new errno with this text? Should be easy and would be the perfect solution,
or do I miss something?

While we are at it, the EOPNOTSUPP that is already there is marked as
needing a better code, so this should also be done.

Considering the man pages, there's also some work to do.

Additionally to the to-be-changed ENODEV there are two undocumented EINVAL.
The list of MNT_* flags is also outdated, there are quite a few new ones
that aren't listed. However I'm not sure if all of them should be listed.

I might also update them, but I need somebody knowledgeable for

Bye, Chris

Content-Type: text/plain; name="mount-diff"
Content-Disposition: attachment; filename="mount-diff"

Index: sys/kern/vfs_syscalls.c
RCS file: /cvsroot/src/sys/kern/vfs_syscalls.c,v
retrieving revision
diff -u -r1.217.2.9 vfs_syscalls.c
--- sys/kern/vfs_syscalls.c	20 Jan 2006 20:48:41 -0000
+++ sys/kern/vfs_syscalls.c	27 Sep 2006 14:46:09 -0000
@@ -296,7 +296,7 @@
 	if ((vfs = vfs_getopsbyname(fstypename)) == NULL) {
-		return (ENODEV);
 	if (vp->v_mountedhere != NULL) {