Subject: Re: i386->vax build fails
To: Havard Eidnes <he@NetBSD.org>
From: Aaron J. Grier <firstname.lastname@example.org>
Date: 07/04/2006 08:57:57
On Tue, Jul 04, 2006 at 04:33:17PM +0200, Havard Eidnes wrote:
> > > Index: macros.h
> > I suppose that works too... I've attached my patch.
> Heh, yours is quite a bit briefer...
it also exposes some other problems and isn't complete. a couple
src/sys/lib/libkern/_que.c looks like it needs to go away, but then I
see macro-fied queue operations in sys/sys/queue.h , so maybe the
inlined macros in sys/arch/vax/include/macros.h need to go away,
although it looks like they may be (single-op) wins on vax.
vax release builds happy now with the attached patch, but I don't see
any macros.h include files for other architectures, so I suspect things
will blow up there.
someone please speak up if this should be redirected into tech-kern.
> > this of course leads to the question why these macros in macros.h
> > are necessary in the first place; wouldn't there be more benefit in
> > revising gcc's inline builtins?
> I can't answer that definitively myself, unfortunately, and therefore
> I'll wait for the portmaster's input on the matter.
of course. are there open PRs for any of these? (I can't find any.)
Aaron J. Grier | "Not your ordinary poofy goof." | email@example.com
"silly brewer, saaz are for pils!" -- virt