Subject: Re: build.sh: iso-image operation not working
To: Jukka Salmi <j+nbsd@2006.salmi.ch>
From: Marcin Jessa <lists@yazzy.org>
List: current-users
Date: 02/03/2006 11:35:31
On Fri, 3 Feb 2006 10:39:47 +0100
Jukka Salmi <j+nbsd@2006.salmi.ch> wrote:

> Hi,
> 
> the recently added `iso-image' operation in src/build.sh does not work
> because the operation's name was not added to the list of valid
> operations in parseoptions(). Moreover, since `iso-image' is not a
> valid shell variable name, it can't be used as an operation name in
> build.sh: parseoptions() does a `eval do_${op}=true' which fails if
> $op is `iso-image'...
> 
> The attached patch should fix these problems by renaming the operation
> and target respectively to `isoimage' in src/build.sh and
> src/Makefile.
> 

Maybe the isoimage target should build all the required floppy images
as well? Also notice the mkisofs warnings.

[root@mail:/usr/src]# ./build.sh -O /usr/obj/ -T /usr/tools/ isoimage 
===> build.sh command: ./build.sh -O /usr/obj/ -T /usr/tools/ isoimage
===> build.sh started: Fri Feb  3 11:27:14 CET 2006
===> MACHINE:          i386
===> MACHINE_ARCH:     i386
===> TOOLDIR path:     /usr/tools
===> DESTDIR path:     /usr/obj/destdir.i386
===> RELEASEDIR path:  /usr/obj/releasedir
===> makewrapper:      /usr/tools/bin/nbmake-i386
===> Updated /usr/tools/bin/nbmake-i386
iso-image ===> etc
rm -f /usr/obj/etc/cdrom.pathlist
echo "i386=/usr/obj/releasedir/i386" >> /usr/obj/etc/cdrom.pathlist
mkdir -p /usr/obj/etc/cdrom.dir
mkdir -p /usr/obj/releasedir/i386/installation/cdrom
mkisofs 2.01.01a03 (i386-unknown-netbsd3.99.15)
mkisofs -J -l -hide-joliet-trans-tbl -r -T  -V NETBSD_39915  -P "The
NetBSD Project"  -m "/usr/obj/releasedir/i386/installation/cdrom"
-quiet -b i386/installation/floppy/boot-big.fs -c boot.catalog
-graft-points -path-list /usr/obj/etc/cdrom.pathlist
-o /usr/obj/releasedir/i386/installation/cdrom/netbsd-i386.iso /usr/obj/etc/cdrom.dir
mkisofs: The option '-P' is reserved by POSIX.1-2001. mkisofs: The
option '-P' means 'do not follow symbolic links'. mkisofs: Mkisofs-2.02
will introduce POSIX semantics for '-P'. mkisofs: Use -publisher in
future to get old mkisofs behavior. mkisofs: Uh oh, I cant find the
boot image 'i386/installation/floppy/boot-big.fs' !

*** Failed target:  iso-image-mi
*** Failed command: mkisofs -J -l -hide-joliet-trans-tbl -r -T -V
NETBSD_39915 -P "The NetBSD Project" -m
"/usr/obj/releasedir/i386/installation/cdrom" -quiet -b
i386/installation/floppy/boot-big.fs -c boot.catalog -graft-points
-path-list /usr/obj/etc/cdrom.pathlist
-o /usr/obj/releasedir/i386/installation/cdrom/netbsd-i386.iso /usr/obj/etc/cdrom.dir
*** Error code 255

Stop.
nbmake: stopped in /usr/src/etc

*** Failed target:  isoimage
*** Failed command: _makedirtarget() { dir="$1"; shift; target="$1";
shift; case "${dir}" in /*) this="${dir}/"; real="${dir}" ;; .)
this=""; real="/usr/src" ;; *) this="${dir}/";
real="/usr/src/${dir}" ;; esac; show=${this:-.}; echo "${target} ===>
${show%/}${1:+ (with: $@)}"; cd "${real}" && /usr/tools/bin/nbmake
_THISDIR_="${this}" "$@" ${target}; }; _makedirtarget etc iso-image ***
Error code 1

Stop.
nbmake: stopped in /usr/src

ERROR: Failed to make isoimage

Cheers, 
Marcin