Hi,

it would be nice if at least all of userland would compile after your commit:

dependall ===> usr.bin/fstat
#   compile  fstat/isofs.o
cc -O2  -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wno-sign-compare -Wno-traditional -Wreturn-type -Wswitch -Wshadow -Wcast-qual -Wwrite-strings  -Werror   -I/src/sys -DINET6    -c    /home/source/src/usr.bin/fstat/isofs.c
In file included from /home/source/src/usr.bin/fstat/isofs.c:59:
/usr/include/isofs/cd9660/cd9660_extern.h:43:2: #error not supposed to be exposed to userland.
In file included from /home/source/src/usr.bin/fstat/isofs.c:60:
/usr/include/isofs/cd9660/cd9660_node.h:40:2: #error not supposed to be exposed to userland.
*** Error code 1 (continuing)

dependall ===> usr.bin/pmap
#    create  pmap/.depend
rm -f .depend
mkdep -d -f .depend -s .o\ .ln main.d pmap.d pmap_ld.d
rm -f .gdbinit
touch .gdbinit
#   compile  pmap/main.o
cc -O2  -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wno-sign-compare -Wno-traditional  -Werror      -c    /home/source/src/usr.bin/pmap/main.c
In file included from /home/source/src/usr.bin/pmap/pmap.h:68,
                 from /home/source/src/usr.bin/pmap/main.c:64:
/usr/include/isofs/cd9660/cd9660_node.h:40:2: #error not supposed to be exposed to userland.
*** Error code 1 (continuing)
#   compile  pmap/pmap.o
cc -O2  -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wno-sign-compare -Wno-traditional  -Werror      -c    /home/source/src/usr.bin/pmap/pmap.c
In file included from /home/source/src/usr.bin/pmap/pmap.h:68,
                 from /home/source/src/usr.bin/pmap/pmap.c:52:
/usr/include/isofs/cd9660/cd9660_node.h:40:2: #error not supposed to be exposed to userland.
*** Error code 1 (continuing)
#   compile  pmap/pmap_ld.o
cc -O2  -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wno-sign-compare -Wno-traditional  -Werror      -c    /home/source/src/usr.bin/pmap/pmap_ld.c
In file included from /home/source/src/usr.bin/pmap/pmap.h:68,
                 from /home/source/src/usr.bin/pmap/pmap.c:52,
                 from /home/source/src/usr.bin/pmap/pmap_ld.c:40:
/usr/include/isofs/cd9660/cd9660_node.h:40:2: #error not supposed to be exposed to userland.
*** Error code 1 (continuing)


Bernd

On Sat, Dec 03, 2005 at 05:34:44PM +0000, Christos Zoulas wrote:
> 
> Module Name:	src
> Committed By:	christos
> Date:		Sat Dec  3 17:34:44 UTC 2005
> 
> Modified Files:
> 	src/sys/fs/adosfs: adosfs.h
> 	src/sys/fs/cd9660: cd9660_extern.h cd9660_mount.h cd9660_node.h
> 	    cd9660_rrip.h iso.h iso_rrip.h
> 	src/sys/fs/filecorefs: filecore.h filecore_extern.h filecore_mount.h
> 	    filecore_node.h
> 	src/sys/fs/msdosfs: bootsect.h bpb.h denode.h direntry.h fat.h
> 	    msdosfsmount.h
> 	src/sys/fs/ntfs: ntfs.h ntfs_compr.h ntfs_ihash.h ntfs_inode.h
> 	    ntfs_subr.h ntfs_vfsops.h ntfsmount.h
> 	src/sys/fs/ptyfs: ptyfs.h
> 	src/sys/fs/smbfs: smbfs.h smbfs_node.h
> 	src/sys/fs/tmpfs: tmpfs.h tmpfs_fifoops.h tmpfs_pool.h tmpfs_specops.h
> 	    tmpfs_vnops.h
> 	src/sys/fs/union: union.h
> 
> Log Message:
> - protect userland exported files against multiple inclusion.
> - make sure that kernel only files don't compile in userland using #error
> - XXX: some kernel only files still get installed.
> - XXX: some files used in userland, don't get installed.
> 
> 
> To generate a diff of this commit:
> cvs rdiff -r1.7 -r1.8 src/sys/fs/adosfs/adosfs.h
> cvs rdiff -r1.15 -r1.16 src/sys/fs/cd9660/cd9660_extern.h
> cvs rdiff -r1.5 -r1.6 src/sys/fs/cd9660/cd9660_mount.h \
>     src/sys/fs/cd9660/iso.h
> cvs rdiff -r1.10 -r1.11 src/sys/fs/cd9660/cd9660_node.h
> cvs rdiff -r1.2 -r1.3 src/sys/fs/cd9660/cd9660_rrip.h
> cvs rdiff -r1.3 -r1.4 src/sys/fs/cd9660/iso_rrip.h
> cvs rdiff -r1.3 -r1.4 src/sys/fs/filecorefs/filecore.h \
>     src/sys/fs/filecorefs/filecore_node.h
> cvs rdiff -r1.10 -r1.11 src/sys/fs/filecorefs/filecore_extern.h
> cvs rdiff -r1.5 -r1.6 src/sys/fs/filecorefs/filecore_mount.h
> cvs rdiff -r1.2 -r1.3 src/sys/fs/msdosfs/bootsect.h
> cvs rdiff -r1.3 -r1.4 src/sys/fs/msdosfs/bpb.h src/sys/fs/msdosfs/fat.h
> cvs rdiff -r1.10 -r1.11 src/sys/fs/msdosfs/denode.h \
>     src/sys/fs/msdosfs/msdosfsmount.h
> cvs rdiff -r1.4 -r1.5 src/sys/fs/msdosfs/direntry.h
> cvs rdiff -r1.11 -r1.12 src/sys/fs/ntfs/ntfs.h
> cvs rdiff -r1.1 -r1.2 src/sys/fs/ntfs/ntfs_compr.h
> cvs rdiff -r1.2 -r1.3 src/sys/fs/ntfs/ntfs_ihash.h \
>     src/sys/fs/ntfs/ntfs_inode.h
> cvs rdiff -r1.4 -r1.5 src/sys/fs/ntfs/ntfs_subr.h \
>     src/sys/fs/ntfs/ntfs_vfsops.h src/sys/fs/ntfs/ntfsmount.h
> cvs rdiff -r1.4 -r1.5 src/sys/fs/ptyfs/ptyfs.h
> cvs rdiff -r1.11 -r1.12 src/sys/fs/smbfs/smbfs.h
> cvs rdiff -r1.9 -r1.10 src/sys/fs/smbfs/smbfs_node.h
> cvs rdiff -r1.9 -r1.10 src/sys/fs/tmpfs/tmpfs.h
> cvs rdiff -r1.3 -r1.4 src/sys/fs/tmpfs/tmpfs_fifoops.h \
>     src/sys/fs/tmpfs/tmpfs_pool.h
> cvs rdiff -r1.4 -r1.5 src/sys/fs/tmpfs/tmpfs_specops.h
> cvs rdiff -r1.6 -r1.7 src/sys/fs/tmpfs/tmpfs_vnops.h
> cvs rdiff -r1.11 -r1.12 src/sys/fs/union/union.h
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
>