Subject: Re: Re: lib/30923
To: John Nemeth <jnemeth@victoria.tc.ca>
From: Rui Paulo <rpaulo@NetBSD.org>
List: current-users
Date: 08/24/2005 22:26:16
--PGNNI9BzQDUtgA2J
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On 2005.08.24 13:27:10 +0000, John Nemeth wrote:
| Anyways, here's a patch for 2.1:
|=20
| --- login.c.orig 2005-08-24 13:07:05.000000000 -0700
| +++ login.c 2005-08-24 13:08:30.000000000 -0700
| @@ -503,9 +503,7 @@
| * but with insecure terminal, refuse the login attempt.
| */
| if (pwd && !rval && rootlogin && !rootterm(tty)) {
| - (void)fprintf(stderr,
| - "%s login refused on this terminal.\n",
| - pwd->pw_name);
| + (void)printf("Login incorrect\n");
| if (hostname)
| syslog(LOG_NOTICE,
| "LOGIN %s REFUSED FROM %s ON TTY %s",
|=20
| I don't know whether this is considered to be a problem though, since
| it is consistent with traditional Unix behaviour.
I agree this is not a problem since it's mostly a traditional behaviour.
SunOSi, for example, doesn't even check for good/bad password (at least on
SunOS 5.9).
Your patch doesn't look wrong, but I would prefer if we could add a login.c=
onf
attribute to turn on/off this behaviour.
-- Rui Paulo
--PGNNI9BzQDUtgA2J
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (NetBSD)
iD8DBQFDDOX4ZPqyxs9FH4QRAoa3AJ9MWa1m6RgyMQuTi4BiLGB2Ihx4rwCfU77j
V57jUO0cJ4IFr/eeM80aHL4=
=O2Xv
-----END PGP SIGNATURE-----
--PGNNI9BzQDUtgA2J--