Subject: Build broken? (Re: CVS commit: src/usr.sbin/makefs)
To: Frank van der Linden <email@example.com>
From: Valeriy E. Ushakov <firstname.lastname@example.org>
Date: 08/13/2005 17:35:10
On Sat, Aug 13, 2005 at 01:53:01 +0000, Frank van der Linden wrote:
> Module Name: src
> Committed By: fvdl
> Date: Sat Aug 13 01:53:01 UTC 2005
> Modified Files:
> src/usr.sbin/makefs: Makefile makefs.8 makefs.c makefs.h
> Added Files:
> src/usr.sbin/makefs: cd9660.c cd9660.h
> src/usr.sbin/makefs/cd9660: cd9660_conversion.c cd9660_debug.c
> cd9660_eltorito.c cd9660_eltorito.h cd9660_rrip.c cd9660_rrip.h
> cd9660_strings.c cd9660_util.c cd9660_write.c iso.h iso9660_rrip.c
> iso9660_rrip.h iso_rrip.h
> Log Message:
> cd9660 support. Written by Daniel Watt, Walter Deignan, Ryan Gabrys,
> Alan Perez-Rathke and Ram Vedam.
> Prototyping, KNF, WARNS=3 by me.
> Note that this is marked experimental for now. It works well enough to
> make NetBSD/i386 bootable images, but does need more work.
This seems to be broken for "tools" build. Unfortunately, I have to
run now and cannot look further into it, but it seems that the problem
is that cd9660.h doesn't arrange for compat defs to be pulled early.
So what happens is that <assert.h> &co pull in sys/featuretest.h that
define _NETBSD_SOURCE, and when lated cd9660.h pulls is makefs.h, that
in its turn pulls in comapt_defs.h, the latter complains about
_NETBSD_SOURCE and punts.
email@example.com | Zu Grunde kommen
http://www.ptc.spbu.ru/~uwe/ | Ist zu Grunde gehen