Subject: Re: /etc/login.conf required to exist after user(8) changes
To: Hubert Feyrer <hubert@feyrer.de>
From: Lennart Augustsson <lennart@augustsson.net>
List: current-users
Date: 07/29/2005 12:57:22
Hubert Feyrer wrote:
> On Fri, 29 Jul 2005, Jukka Salmi wrote:
>
>> I'm talking about the [1]changes made to src/usr.sbin/user/user.c
>> between revisions 1.81 and 1.82, committed by christos, including
>> "patches from Liam Foy" (was there a PR?).
>
> ...
>
>> The attached patch fixes both problems.
>
>
> I see. Would it be possible to rewrite
>
> + ret = lc != NULL;
>
> as something like
> ret = (lc == NULL)?1:0;
>
> ? It's more readable IMHO.
Well, that's a matter of taste. I find the latter more difficult to
read. Possibly
ret = (lc != NULL);
-- Lennart