Subject: Re: finished importing ath/net80211
To:, David Young <>
From: Bernd Ernesti <>
List: current-users
Date: 06/26/2005 09:28:27

there is a problem while i try to compile a new kernel:

#   compile  PARRESUM/ieee80211_input.o
cc -ffreestanding -g -O2 -Werror -Wall -Wno-main -Wno-format-zero-length -Wpointer-arith -Wmissing-prototypes -Wstrict-prototypes -Wreturn-type -Wswitch -Wshadow -Wcast-qual -Wwrite-strings -Wno-sign-compare -fno-zero-initialized-in-bss -Di386 -I. -I/src/sys/arch -I/src/sys -nostdinc -DPIC_DELAY -DSHMMNI=256 -DSHMSEG=256 -DLKM -DALTQ_PRIQ -DNMBCLUSTERS=8192 -DMSGBUFSIZE=65536 -DPCMCIACISDEBUG -DUSB_DEBUG -DMAXUSERS=64 -D_KERNEL -D_KERNEL_OPT -I/src/sys/dist/ipf -c /src/sys/net80211/ieee80211_input.c
/src/sys/net80211/ieee80211_input.c: In function `ieee80211_input':
/src/sys/net80211/ieee80211_input.c:170: warning: unused variable `pktattr'
*** Error code 1

Maybe because of the follwing kernel options (ALTQ should be enough to trigger
that error):
options         ALTQ            # Manipulate network interfaces' output queues
options         ALTQ_CBQ        # Class-Based Queueing 
options         ALTQ_CDNR       # Diffserv Traffic Conditioner
options         ALTQ_FIFOQ      # First-In First-Out Queue 
options         ALTQ_HFSC       # Hierarchical Fair Service Curve
options         ALTQ_PRIQ       # Priority Queueing
options         ALTQ_RED        # Random Early Detection
options         ALTQ_RIO        # RED with IN/OUT
options         ALTQ_WFQ        # Weighted Fair Queueing

Hmm, there were some additional lines before you imported the new source.
Putting that back fixed the problem, but I don't know if thats correct.


Index: ieee80211_input.c
RCS file: /cvsroot/src/sys/net80211/ieee80211_input.c,v
retrieving revision 1.41
diff -b -u -r1.41 ieee80211_input.c
--- ieee80211_input.c	26 Jun 2005 04:31:51 -0000	1.41
+++ ieee80211_input.c	26 Jun 2005 07:25:52 -0000
@@ -573,6 +573,11 @@
 			if (m1 != NULL) {
+#ifdef ALTQ
+				if (ALTQ_IS_ENABLED(&ifp->if_snd))
+					altq_etherclassify(&ifp->if_snd, m1,
+					    &pktattr);
 				int len = m1->m_pkthdr.len;
 				IF_ENQUEUE(&ifp->if_snd, m1);
 				if (m != NULL)