Subject: Another kernel build failure: net/if_ppp.c
To: None <current-users@netbsd.org>
From: Michael Graff <explorer@flame.org>
List: current-users
Date: 03/31/2005 11:53:45
--nextPart1798153.Wj4iY5camA
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Here's the error:

=2D-- if_ppp.o ---
=2E./../../../net/if_ppp.c: In function `pppoutput':
=2E./../../../net/if_ppp.c:883: warning: `ifq' might be used uninitialized =
in=20
this function
*** [if_ppp.o] Error code 1
1 error

and sure enough, when looking at if_ppp.c, I see (around line 1028 or so) t=
he=20
following:

    s =3D splnet();
    if (mode =3D=3D NPMODE_QUEUE) {
	/* XXX we should limit the number of packets on this queue */
	*sc->sc_npqtail =3D m0;
	m0->m_nextpkt =3D NULL;
	sc->sc_npqtail =3D &m0->m_nextpkt;
    } else {
	if (m0->m_flags & M_HIGHPRI)
		ifq =3D &sc->sc_fastq;
	if ((error =3D ifq_enqueue2(&sc->sc_if, ifq, m0
		ALTQ_COMMA ALTQ_DECL(&pktattr))) !=3D 0) {
	    splx(s);
	    sc->sc_if.if_oerrors++;
	    sc->sc_stats.ppp_oerrors++;
	    return (error);
	}
	ppp_restart(sc);
    }
    ifp->if_opackets++;
    ifp->if_obytes +=3D len;

    splx(s);


Sure enough, if M_HIGHPRI isn't set, ifq will in fact not be set.

Does anyone trial-compile before commit anymore?  :P

=2D-Michael

--nextPart1798153.Wj4iY5camA
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (NetBSD)

iD8DBQBCTCsfl6Nz7kJWYWYRAutzAJ92L2ChXmf/XPcJeyXHYOo8BzZR5ACcDN9U
P49MReaF1ZNxTAetawfcWeA=
=UPwI
-----END PGP SIGNATURE-----

--nextPart1798153.Wj4iY5camA--