On Fri, Mar 04, 2005 at 08:42:08AM +0000, Charles M. Hannum wrote:

> Could people with OHCI devices please test the following patch and let me know 
> if they experience any new problems?  It would be especially useful to get 
> results from non-PC platforms -- e.g. embedded OHCI controllers on some ARM 
> systems, Macs, etc.
> 
> Also, if you can compare performance (e.g. bulk read/write of a USB flash 
> device) before/after, that would be useful.  In theory, you shouldn't notice 
> any difference.
> 
> If I don't get results back, I'm going to go ahead and commit it.  You've been 
> warned.

For an Alchemy Au1500 on-chip OHCI controller (same dmesg before and
after patch):

ohci0 at aubus0 addr 0x10100000 irq 26: Au1X00 OHCI
ohci0: OHCI version 1.0
usb0 at ohci0: USB revision 1.0
uhub0 at usb0
uhub0: vendor 0x0000 OHCI root hub, class 9/0, rev 1.00/1.00, addr 1
uhub0: 2 ports with 2 removable, self powered
umass0 at uhub0 port 2 configuration 1 interface 0
umass0: ICSI USB2.0 Card Reader, rev 2.00/1.4f, addr 2
umass0: using SCSI over Bulk-Only
scsibus0 at umass0: 2 targets, 4 luns per target
sd0 at scsibus0 target 0 lun 0: <ICSI, IC1210        CF, 1.4F> disk removable
sd0: drive offline
sd1 at scsibus0 target 0 lun 1: <ICSI, IC1210        MS, 1.4F> disk removable
sd1: 228 MB, 500 cyl, 8 head, 16 sec, 512 bytes/sect x 466944 sectors
sd2 at scsibus0 target 0 lun 2: <ICSI, IC1210    MMC/SD, 1.4F> disk removable
sd2: drive offline
sd3 at scsibus0 target 0 lun 3: <ICSI, IC1210        SM, 1.4F> disk removable
sd3: drive offline

Before patch, dd from rsd1c with 64k blocks gets:

16777216 bytes transferred in 18.195 secs (922078 bytes/sec)

After patch, dd from rsd1c with 64k blocks gets:

16777216 bytes transferred in 18.198 secs (921926 bytes/sec)

which I'm happy enough to call "the same".

Simon.
--
Simon Burge                                   <simonb@wasabisystems.com>
NetBSD Development, Support and Service:   http://www.wasabisystems.com/