--sgneBHv3152wZ8jf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jan 27, 2005 at 10:51:23AM +0900, enami tsugutomo wrote:
> Kouichirou Hiratsuka <hira@po6.nsk.ne.jp> writes:
>=20
> >   http://mail-index.NetBSD.org/source-changes/2005/01/25/0028.html
>=20
> At least, this looks inconsistent.
>=20
> enami.
>=20
> Index: ffs_vnops.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /cvsroot/src/sys/ufs/ffs/ffs_vnops.c,v
> retrieving revision 1.67
> diff -c -r1.67 ffs_vnops.c
> *** ffs_vnops.c	25 Jan 2005 23:55:21 -0000	1.67
> --- ffs_vnops.c	27 Jan 2005 01:37:19 -0000
> ***************
> *** 461,467 ****
>   		waitfor =3D (ap->a_flags & FSYNC_WAIT) ? UPDATE_WAIT : 0;
>   	error =3D VOP_UPDATE(vp, NULL, NULL, waitfor);
>  =20
> ! 	if (error =3D=3D 0 && ap->a_flags & FSYNC_WAIT) {
>   		int i =3D 0;
>   		VOP_IOCTL(VTOI(vp)->i_devvp, DIOCCACHESYNC, &i, FWRITE,
>   			ap->a_p->p_ucred, ap->a_p);
> --- 465,471 ----
>   		waitfor =3D (ap->a_flags & FSYNC_WAIT) ? UPDATE_WAIT : 0;
>   	error =3D VOP_UPDATE(vp, NULL, NULL, waitfor);
>  =20
> ! 	if (error =3D=3D 0 && ap->a_flags & FSYNC_CACHE) {
>   		int i =3D 0;
>   		VOP_IOCTL(VTOI(vp)->i_devvp, DIOCCACHESYNC, &i, FWRITE,
>   			ap->a_p->p_ucred, ap->a_p);

That's the revision I checked in yesterday, and it's in rev 1.68 of the=20
file. You're right that it was not consistent with the other cases; it was=
=20
the bug. :-)

Take care,

Bill

--sgneBHv3152wZ8jf
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (NetBSD)

iD8DBQFB+UFYWz+3JHUci9cRAvwlAJ9eUp93bKalQ10hJOeqxrlOaCvz0ACeOhHE
lXUggpFudDj9kRMepMx+yE4=
=EmWg
-----END PGP SIGNATURE-----

--sgneBHv3152wZ8jf--