Subject: Re: sys/dev/pci/agp_amd.c not matching PCI_PRODUCT_AMD_SC761_SC.
To: None <current-users@netbsd.org>
From: Christos Zoulas <christos@zoulas.com>
List: current-users
Date: 10/20/2004 21:37:09
In article <20041020224032.28347afd.juan@xtraeme.nopcode.org>,
Juan RP <juan@xtraeme.nopcode.org> wrote:
>-=-=-=-=-=-
>
>My system contains an AMD 761 System controller detected by NetBSD
>(2.0/-current), but the agp driver couldn't be attached due to a missing
>case in agp_amd_match().
>
>Index: dev/pci/agp_amd.c
>===================================================================
>RCS file: /cvsroot/src/sys/dev/pci/agp_amd.c,v
>retrieving revision 1.9
>diff -b -u -r1.9 agp_amd.c
>--- dev/pci/agp_amd.c   31 Jan 2003 00:07:39 -0000      1.9
>+++ dev/pci/agp_amd.c   20 Oct 2004 20:38:36 -0000
>@@ -160,6 +160,7 @@
> 
>        switch (PCI_PRODUCT(pa->pa_id)) {
>        case PCI_PRODUCT_AMD_SC751_SC:
>+       case PCI_PRODUCT_AMD_SC761_SC:
>        case PCI_PRODUCT_AMD_SC762_NB:
>                return 1;
>        }
>
>Applying the patch:
>
>pchb0 at pci0 dev 0 function 0
>pchb0: Advanced Micro Devices AMD761 System Controller (rev. 0x14)
>agp0 at pchb0: aperture at 0xe0000000, size 0x4000000
>
>Without the patch applied:
>
>pchb0 at pci0 dev 0 function 0
>pchb0: Advanced Micro Devices AMD761 System Controller (rev. 0x14)
>agp at pchb0 not configured
>
>Is it ok to commit and request a pullup for 2-0?

Sure, go ahead.

christos