Subject: sys/dev/pci/agp_amd.c not matching PCI_PRODUCT_AMD_SC761_SC.
To: None <current-users@NetBSD.org>
From: Juan RP <juan@xtraeme.nopcode.org>
List: current-users
Date: 10/20/2004 22:40:32
--Signature=_Wed__20_Oct_2004_22_40_32_+0200_KX2cOqmS.Yn.avt.
Content-Type: text/plain; charset=US-ASCII
Content-Disposition: inline
Content-Transfer-Encoding: 7bit


My system contains an AMD 761 System controller detected by NetBSD
(2.0/-current), but the agp driver couldn't be attached due to a missing
case in agp_amd_match().

Index: dev/pci/agp_amd.c
===================================================================
RCS file: /cvsroot/src/sys/dev/pci/agp_amd.c,v
retrieving revision 1.9
diff -b -u -r1.9 agp_amd.c
--- dev/pci/agp_amd.c   31 Jan 2003 00:07:39 -0000      1.9
+++ dev/pci/agp_amd.c   20 Oct 2004 20:38:36 -0000
@@ -160,6 +160,7 @@
 
        switch (PCI_PRODUCT(pa->pa_id)) {
        case PCI_PRODUCT_AMD_SC751_SC:
+       case PCI_PRODUCT_AMD_SC761_SC:
        case PCI_PRODUCT_AMD_SC762_NB:
                return 1;
        }

Applying the patch:

pchb0 at pci0 dev 0 function 0
pchb0: Advanced Micro Devices AMD761 System Controller (rev. 0x14)
agp0 at pchb0: aperture at 0xe0000000, size 0x4000000

Without the patch applied:

pchb0 at pci0 dev 0 function 0
pchb0: Advanced Micro Devices AMD761 System Controller (rev. 0x14)
agp at pchb0 not configured

Is it ok to commit and request a pullup for 2-0?

Thanks.

--Signature=_Wed__20_Oct_2004_22_40_32_+0200_KX2cOqmS.Yn.avt.
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (NetBSD)

iD8DBQFBds1DypkLYVDran0RArUxAKC0kaRmql6QPJp6p2TnDMpp8TV0LgCfSPke
2Di+6yZYn8ni0JQ+gM+0G7k=
=i+pS
-----END PGP SIGNATURE-----

--Signature=_Wed__20_Oct_2004_22_40_32_+0200_KX2cOqmS.Yn.avt.--