Subject: Changes to net/if.c cause panics (was: CVS commit: src/sys/net)
To: Jun-ichiro itojun Hagino <>
From: Matthias Scheler <>
List: current-users
Date: 10/07/2004 09:54:09
On Thu, Oct 07, 2004 at 05:16:19AM +0900, enami tsugutomo wrote:
> > Log Message:
> > call dom_ifattach[] at consistent state.  before this commit,
> > dom_ifattach[] was called after interface attach is completely done for
> > non-cloning interface, and from within if_attach() for cloning interface
> > (which was wrong).
> >
> > To generate a diff of this commit:
> > cvs rdiff -r1.144 -r1.145 src/sys/net/if.c
> I guess this breaks removable network interface (like xx at cardbus
> etc) since they don't exist when main() calls if_attachdomain().

It seems that this change causes much more problems. My system kept crashing
or freezing frequently because of that change. Several attempts to complete
a NetBSD build failed because the system died. And my system doesn't use
any removable network interfaces (unless the unused "fw0" counts as a
removable interface).

After backing out the above change in my source tree the system stayed
up the whole night and completed a NetBSD build without problems.
Markus W Kilbinger reported similar problems. If backing out the
change fixes his problem, too, I will revert the last two revisions
in the NetBSD source tree.

	Kind regards

Matthias Scheler