Subject: wdc_amiga (Re: CVS commit: src/sys/dev)
To: None <current-users@netbsd.org>
From: Jukka Andberg <jandberg@NetBSD.org>
List: current-users
Date: 08/22/2004 18:13:44
  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--0-1744963922-1093187624=:314
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed

> Module Name:	src
> Committed By:	mycroft
> Date:		Mon Aug 16 14:47:31 UTC 2004
>
> Modified Files:
> 	src/sys/dev/isa: wdc_isa.c
> 	src/sys/dev/pcmcia: wdc_pcmcia.c
>
> Log Message:
> wdc_init_shadow_regs() must now be called after ch_wdc is filled in, or we get
> a null pointer dereference.

I think we need something similar to wdc_amiga to stop it from crashing. 
Attached patch fixes it for me, can anyone with a clue see if it's ok
to commit?
--0-1744963922-1093187624=:314
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="wdc_amiga.diff"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.NEB.4.60.0408221813440.314@cs181014246.pp.htv.fi>
Content-Description: diff
Content-Disposition: attachment; filename="wdc_amiga.diff"

SW5kZXg6IHdkY19hbWlnYS5jDQo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpS
Q1MgZmlsZTogL2N2c3Jvb3Qvc3JjL3N5cy9hcmNoL2FtaWdhL2Rldi93ZGNf
YW1pZ2EuYyx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMjMNCmRpZmYgLXUg
LXUgLTggLXIxLjIzIHdkY19hbWlnYS5jDQotLS0gd2RjX2FtaWdhLmMJMjAg
QXVnIDIwMDQgMDY6Mzk6MzggLTAwMDAJMS4yMw0KKysrIHdkY19hbWlnYS5j
CTIyIEF1ZyAyMDA0IDE1OjA1OjM4IC0wMDAwDQpAQCAtMTI3LDMyICsxMjcs
MzQgQEANCiANCiAJCQlidXNfc3BhY2VfdW5tYXAod2RyLT5jbWRfaW90LA0K
IAkJCSAgICB3ZHItPmNtZF9iYXNlaW9oLCAweDQwKTsNCiAJCQlwcmludGYo
IiVzOiBjb3VsZG4ndCBtYXAgcmVnaXN0ZXJzXG4iLA0KIAkJCSAgICBzYy0+
c2Nfd2RjZGV2LnNjX2F0YWMuYXRhY19kZXYuZHZfeG5hbWUpOw0KIAkJCXJl
dHVybjsNCiAJCX0NCiAJfQ0KLQl3ZGNfaW5pdF9zaGFkb3dfcmVncygmc2Mt
PnNjX2NoYW5uZWwpOw0KIA0KIAlpZiAoc2MtPnNjX2ExMjAwKQ0KIAkJd2Ry
LT5jdGxfaW9oID0gc2MtPmN0bF9pb3QuYmFzZTsNCiAJZWxzZSBpZiAoYnVz
X3NwYWNlX3N1YnJlZ2lvbih3ZHItPmNtZF9pb3QsDQogCSAgICB3ZHItPmNt
ZF9iYXNlaW9oLCAweDQwNiwgMSwgJndkci0+Y3RsX2lvaCkpDQogCQlyZXR1
cm47DQogDQogCXNjLT5zY193ZGNkZXYuc2NfYXRhYy5hdGFjX2NhcCA9IEFU
QUNfQ0FQX0RBVEExNjsNCiAJc2MtPnNjX3dkY2Rldi5zY19hdGFjLmF0YWNf
cGlvX2NhcCA9IDA7DQogCXNjLT5zY19jaGFubGlzdFswXSA9ICZzYy0+c2Nf
Y2hhbm5lbDsNCiAJc2MtPnNjX3dkY2Rldi5zY19hdGFjLmF0YWNfY2hhbm5l
bHMgPSBzYy0+c2NfY2hhbmxpc3Q7DQogCXNjLT5zY193ZGNkZXYuc2NfYXRh
Yy5hdGFjX25jaGFubmVscyA9IDE7DQogCXNjLT5zY19jaGFubmVsLmNoX2No
YW5uZWwgPSAwOw0KIAlzYy0+c2NfY2hhbm5lbC5jaF9hdGFjID0gJnNjLT5z
Y193ZGNkZXYuc2NfYXRhYzsNCiAJc2MtPnNjX2NoYW5uZWwuY2hfcXVldWUg
PSAmc2MtPnNjX2NocXVldWU7DQorDQorCXdkY19pbml0X3NoYWRvd19yZWdz
KCZzYy0+c2NfY2hhbm5lbCk7DQorDQogCXNjLT5zY19pc3IuaXNyX2ludHIg
PSB3ZGNfYW1pZ2FfaW50cjsNCiAJc2MtPnNjX2lzci5pc3JfYXJnID0gc2M7
DQogCXNjLT5zY19pc3IuaXNyX2lwbCA9IDI7DQogCWFkZF9pc3IgKCZzYy0+
c2NfaXNyKTsNCiANCiAJaWYgKHNjLT5zY19hMTIwMCkNCiAJCWdheWxlLmlu
dGVuYSB8PSBHQVlMRV9JTlRfSURFOw0KIA0K

--0-1744963922-1093187624=:314--