Subject: Re: CVS commit: src/sys/dev/ic
To: TAMURA Kent <kent@NetBSD.org>
From: Love <lha@stacken.kth.se>
List: current-users
Date: 08/20/2004 17:28:56
--=-=-=


TAMURA Kent <kent@NetBSD.org> writes:

>> > Modified Files:
>> > 	src/sys/dev/ic: ac97.c
>> > Log Message:
>> > Check power states after codec reset.  This change fixes a
>> > resume problem on some boards.
>> > Patch provided by Joachim Thiemann in PR kern/26457
>> 
>> I think the auich is wrong, it doesn't wait until the codec is ready.
>> 
>> The spec clearly say that you can rely on the bit then the chip
>> (auich) have entered busmastering mode.
>
> I know the busmastering/codec-ready issue in auich.  But it does
> not mean ac97.c was not wrong.

Sure, its not "wrong", its just total unnesscery if the driver does the
right thing and there is no comment why the "quirk" is there.

Love


--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (NetBSD)

iQIVAwUAQSYYuhZyDLTSep3UAQK2wQ/+NDT6bFcvUvBZqUkEM+7erj1J1mGVA4zA
3bOWstB3uZhQGFO5yFM4vprelULrCwV7HWOwS9xOiUBTgBfv/APnPBIfsL8cPZ0W
7+Zp86p1TtpcboOOdmAcCqtWop59YhZlVyRWZ3IpBumb5Rpn+3DLrRsheiFPnHxr
drEx7hCrZaHwqVhbLEMaPMAs/4UKn3R6tPqBI0sZ3GXY27LBVvAukIQrN1asvp3W
KEB7hGcwAh/UnfTCYj2SbinnyL6IKnGJNCmuA7tw+I8eyWxi2JRXOaLbstgwYVqx
vSj0BK2h3y0o4dFTTqYpyqUrRVd9TG49T/mS219HJ4AtQgg/WR5tzpZa9TdFB0Uw
cViPj4G1FFdPUGMEXTEoalCGw9+cB8z+6vGR4HGYFOD5EDYD+gQisOXMPJWNKmYh
hsCzLRkJFir83vUL8zXAQivfyfIKAB7pUOwHVhse5R8RRg4Hf69tBAdP3s92XKo/
V/vUt2OwjM5+O3Q5aV4rvgPM4DlQZz8eP8J5Wr6wjz2UmHMVNzoxPmzCSqzEucGu
Vh+d2hOk1rCnmIfCvYAG5X4js14Uc9YdMo/azp+8bF4LUoU6VVkCje3NOjr3dkZo
+0NJ9mLbW2kCrT3BmYknMPvbR/c1CrCabZiCRjY4LImPnLIyavqfCGsZkiVVKauz
+M+NFqCZBvQ=
=Iwbc
-----END PGP SIGNATURE-----
--=-=-=--