On Thu, Jul 15, 2004 at 09:36:24PM -0400, Jan Schaumann wrote:
> William Allen Simpson <wsimpson@greendragon.com> wrote:
>  
> > Next, my PR diffs were written as I personally tested:
> >   cd /root/etc
> >   ./etcupdate -s /root/etc
> > 
> > Instead, they modified to:
> >   cd /root/etc
> >   ./postinstall -s /root check
> > 
> > Doesn't this remove old files before the new versions are installed?  
> > Was this tested extensively?
> 
> I'm not sure of this in particular was tested.  Which PR was that?
> 21923?  I've CC'd jmc@, who did incorporate your changes into the
> documentation, maybe he can comment on why the changes were made.
> 
> (I've just now made some of the suggestions you made in this mail,
> though.)

The patches didn't directly apply anymore so some of that was tested directly
and some may have just been typo'd.

> 
> > Finally, my PR diffs were written as I personally tested:
> >   tar -zxpf ~/comp.tgz
> >   ...
> >   tar -zxpf ~/base.tgz
> >   shutdown -r now
> > 
> > Instead, they modified to:
> >   tar -zxpf ~/base.tgz
> >   tar -zxpf ~/comp.tgz
> >   ...</b></tt><br>
> >   /usr/sbin/etcupdate -b /root
> >   shutdown -r now
> > 
> > I am absolutely positive this will not always work, as I've been bitten 
> > by this mistake!  Installing base has to be done last, as tar is in base,
> > and with any changes to tar and the libraries it accesses *boom*!
> 
> Yes, I have made a habit of doing base.tgz in the end, too, so I changed
> that as well.

Never been bit by that myself, but ok.

> 
> > And why etcupdate here?
> 
> jmc?

To make sure correct rc.d scripts are in place. 

James

> 
> -Jan
> 
> -- 
> 'I have reached an age where my main purpose is not to receive
> messages.' --- Umberto Eco, quoted in the New Yorker