Subject: Re: i386 build fails at running fc-cache
To: None <current-users@NetBSD.org>
From: Christian Biere <firstname.lastname@example.org>
Date: 02/02/2004 22:10:13
Content-Type: text/plain; charset=us-ascii
Luke Mewburn wrote:
> | This smells like off-by-one if not two.
> It failed because $HOME wasn't set, so strlen((char*)home) dumped core ...
> That's what the patch is working around.
Sorry, I shouldn't have commented on a excerpt from the complete code.
There's no such off-by-one bug, of course. Increasing ``s'' before doing
the strlen() would have made this more obvious, though. Well, replacing
``~'' by $HOME even if not followed by a ``/'' looks a little strange to me
but it's documented this way. I also wonder why they ignore pw->pw_dir.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (NetBSD)
-----END PGP SIGNATURE-----