Greywolf <greywolf@starwolf.com> writes:

> GAW> 	/* could be a tty iff it is a character device */
> GAW> 	*couldbetty = S_ISCHR(st.st_mode);
> GAW>
> GAW> [[...]]
> GAW>
> GAW> 	if (couldbetty && isatty(fp->_file))
> 
> Disregarding that we're trying to compare a pointer with a value

The two snippets of code are not in the same function and couldbetty
doesn't have the same type in these functions. Otherwise, the test
looks fine to me.

 Aymeric