On Mon, Oct 06, 2003 at 01:06:23PM +0300, Martti Kuparinen wrote:
> Christos Zoulas wrote:
> 
> >>How can I detect the "second" CPU on my 2.8GHz Intel P4 with HT?
> >>Hyperthreading is enabled in the BIOS...
> > 
> > You need MPACPI defined, because the second CPU is only defined in the
> > ACPI tables, and not the MPBIOS ones.
> 
> Hmmm, something is wrong.
> 
> 
> ../../../../arch/x86/x86/acpi_machdep.c: In function 
> `acpi_md_OsInstallInterruptHandler':
> ../../../../arch/x86/x86/acpi_machdep.c:120: warning: unused variable `i'
> ../../../../arch/x86/x86/acpi_machdep.c:120: warning: unused variable `h'
> 
> 
> What's wrong with this configuration file?

ioapic*         at mainbus? apid ?

In the meantime, I propose the following patch, since i and h are used
only when defined(MPACPI) && NIOAPIC > 0.

Index: acpi_machdep.c
===================================================================
RCS file: /cvsroot/src/sys/arch/x86/x86/acpi_machdep.c,v
retrieving revision 1.4
diff -u -r1.4 acpi_machdep.c
--- acpi_machdep.c      2003/09/06 14:38:43     1.4
+++ acpi_machdep.c      2003/10/06 11:03:19
@@ -116,10 +116,10 @@
        struct pic *pic;
        int irq, pin, trigger;
        struct acpi_intr_defer *aip;
+#if NIOAPIC > 0
 #ifdef MPACPI
        int i, h;
 #endif
-#if NIOAPIC > 0
        struct ioapic_softc *sc;
 #endif
 #if defined(MPACPI) || NIOAPIC > 0

Quentin Garnier.