Subject: src/lib/libc/gen/bswap64.c rev 1.4
To: None <current-users@netbsd.org>
From: Brian A. Seklecki <lavalamp@spiritual-machines.org>
List: current-users
Date: 08/09/2003 23:51:28
that last change two hours ago is causing some breakage (confirmed by
dive@endersgame).  i get my source-changes@ in digest, so i don't know
if any other commits just then would affect this, but the diff in cvs
didn't show any includes related changes:


CC=/usr/src/obj/tooldir.NetBSD-1.6R-i386/bin/i386--netbsdelf-gcc
/usr/src/obj/tooldir.NetBSD-1.6R-i386/bin/i386--netbsdelf-lint -chapbxzF
-w -X 272 -d /home/seklecki/D/usr/include -D_LIBC -DLIBC_SCCS
-DSYSLIBC_SCCS -D_REENTRANT -I/usr/src/lib/libc/include -DHESIOD -DINET6
-DNLS -DYP -D__DBINTERFACE_PRIVATE -DI18NMODULE_MAJOR=4
-I/usr/src/libexec/ld.elf_so -I/usr/src/lib/libc/dlfcn -DCITRUS_ICONV
-DWITH_RUNE -I/usr/src/lib/libc -DRESOLVSORT -I. -DPOSIX_MISTAKE
-DPORTMAP -DFLOATING_POINT  -i /usr/src/lib/libc/gen/bswap64.c
/usr/src/lib/libc/gen/bswap64.c(41): warning: extra bits set to 0 in
conversion of 'unsigned long' to 'unsigned long long', op & [309]
/usr/src/lib/libc/gen/bswap64.c(41): warning: conversion to 'unsigned
int' due to prototype, arg #1 [259]
/usr/src/lib/libc/gen/bswap64.c(41): warning: conversion from 'unsigned
long long' may lose accuracy, arg #1 [298]
/usr/src/lib/libc/gen/bswap64.c(42): warning: extra bits set to 0 in
conversion of 'unsigned long' to 'unsigned long long', op & [309]
/usr/src/lib/libc/gen/bswap64.c(42): warning: conversion to 'unsigned
int' due to prototype, arg #1 [259]
/usr/src/lib/libc/gen/bswap64.c(42): warning: conversion from 'unsigned
long long' may lose accuracy, arg #1 [298]
*** Error code 1

Stop.
nbmake: stopped in /usr/src/lib/libc

rdiff:

----------------------------
revision 1.4
date: 2003/08/09 22:37:49;  author: martin;  state: Exp;  lines: +25 -8
Split into a 64 bit version (straight forward shifting and masking) and
a 32 bit one with two 32 bit operations with two temporaries later
combined.

This avoids the strict alias violating magic used before, thereby
probably fixing PR bin/22313.
----------------------------

-- 

Thanks,
	-Brian

NOTE: When replying to a mailing list post, please be sure to reply to
the /list/ and cc: or bcc: myself as I am unable to promise a timely
response.