Subject: Re: error in sys/compat/common/compat_file.c
To: None <current-users@netbsd.org>
From: Hisashi T Fujinaka <htodd@twofifty.com>
List: current-users
Date: 06/05/2003 17:21:49
On Thu, 5 Jun 2003, Hisashi T Fujinaka wrote:

> On Fri, 6 Jun 2003, Simon Burge wrote:
>
> > Hisashi T Fujinaka wrote:
> >
> > > Line 497 looks like a partial line.
> >
> > Looks OK to me on a fresh cvs update:
> >
> >    493          if (strlen(name) >= sizeof(sun.sun_path))
> >    494                  error = ENAMETOOLONG;
> >    495          (void)strncpy(sun.sun_path, name, sizeof(sun.sun_path));
> >    496          free((void *)name, M_TEMP);
> >    497          if (error)
> >    498                  return error;
> >    499
> >
> > Simon.
> > --
> > Simon Burge                            <simonb@wasabisystems.com>
> > NetBSD Support and Service:         http://www.wasabisystems.com/
>
> Yay! only 7 hours after I posted. Here's what was there before.
>
> 492     name = oksun->sun_path;
> 493     if ((error = emul_find(p, NULL, p->p_emul->e_path,
> 494         name, &name, CHECK_ALT_FL_CREAT)) != 0)
> 495         goto out2;
> 496
> 497     namelen, strlen(oksun->sun_path), strlen(name));
> 498     /*
> 499      * Rebuild a new struct sockaddr_un and store it in userspace.
> 500      */

Woo! That sounded a bit snotty, so let me say I didn't mean it to be
that way. (It's in the mid-90s Fahrenheit here and I'm not used to it.
:) )

-- 
Hisashi T Fujinaka - htodd@twofifty.com
BSEE (6/86) + BSChem (3/95) + BAEnglish (8/95) + $2.50 = mocha latte