Hisashi T Fujinaka <htodd@twofifty.com> typed:
: On Tue, 17 Sep 2002, Jason R Thorpe wrote:
:> On Tue, Sep 17, 2002 at 08:07:46PM -0700, Hisashi T Fujinaka wrote:
:>  > Probably bad timing, once again.
:>  > nbmake: "/usr/src/Makefile" line 187: Malformed conditional
:>  > (${TOOLCHAIN_MISSING} == "yes" && !defined(EXTERNAL_TOOLCHAIN))
:>  > nbmake: "/usr/src/Makefile" line 190: if-less elif
:>  > nbmake: "/usr/src/Makefile" line 190: Missing dependency operator
:>  > nbmake: "/usr/src/Makefile" line 192: if-less endif
:>  > nbmake: "/usr/src/Makefile" line 192: Need an operator
:>  > nbmake: Fatal errors encountered -- cannot continue
:>  > nbmake: "/usr/src/share/mk/bsd.own.mk" line 56: warning: "cd /usr/src &&
:>  > /tmp/nbbuild13670/nbmake -V .OBJDIR" returned non-zero status

:> ...interesting.  I did a full build before I checked those changes
:> in, and just double-checked, and I didn't forget to check anything in.
:> What are the RCS IDs at the top of src/Makefile and src/share/mk/bsd.own.mk?
: #   $NetBSD: Makefile,v 1.187 2002/09/17 23:18:25 thorpej Exp $
: #       $NetBSD: bsd.own.mk,v 1.309 2002/09/15 17:07:14 thorpej Exp $
: Bad timing? :)

It's weird since the same commit put in Makefile 1.187 and bsd.own.mk 1.310
I have the same lag in my bsd.own.mk

Also, the logic in basesrc/Makefile

    .if ${TOOLCHAIN_MISSING} == "yes" && !defined(EXTERNAL_TOOLCHAIN)
    .elif defined(EXTERNAL_TOOLCHAIN)
    .endif

could be more cleanly expressed as

    .if defined(EXTERNAL_TOOLCHAIN)
    .elif ${TOOLCHAIN_MISSING} == "yes"
    .endif

Regards,
-- 
Geoff Wing : <gcw@pobox.com>
Rxvt Stuff : <gcw@rxvt.org>
Zsh Stuff  : <gcw@zsh.org>