Subject: Re: May 14 scsi changes: driver support needed?
To: Manuel Bouyer <email@example.com>
From: Jason R Thorpe <firstname.lastname@example.org>
Date: 05/21/2001 08:12:26
On Mon, May 21, 2001 at 03:40:58PM +0200, Manuel Bouyer wrote:
> Hum, this means we need to add __attribute__((packed)) to all structs defining
> SCSI commands or results ? Looks strange to me, as this worked before without
> this ... Or maybe we need them only for scsipi_mode_sense and
> scsipi_mode_select, as they're the only ones with union in the struct ?
In fact, a union of 2 structs. Structres have minimum alignments on
some architectures, regardless of what they have inside them.
We should add __packed__ to all of SCSI "wire protocol" structures,
-- Jason R. Thorpe <email@example.com>