Subject: Re: May 14 scsi changes: driver support needed?
To: Ignatios Souvatzis <firstname.lastname@example.org>
From: Manuel Bouyer <email@example.com>
Date: 05/21/2001 15:40:58
On Fri, May 18, 2001 at 11:13:09PM +0200, Ignatios Souvatzis wrote:
> On Fri, May 18, 2001 at 10:10:26PM +0200, Ignatios Souvatzis wrote:
> > Hm, when I browsed the may 14 diffs, I noticed that you're using nested
> > structs and unions for on-wire data in the new code. Maybe this stuff needs
> > to be __attribute__((packed)) for it to work with m68k compilers?
> Yes. After testing, I committed my change as scsipi_all.h 1.18.
> Somebody should re-read the change diffs to determine whether there are more
> problems like this lurking.
Hum, this means we need to add __attribute__((packed)) to all structs defining
SCSI commands or results ? Looks strange to me, as this worked before without
this ... Or maybe we need them only for scsipi_mode_sense and
scsipi_mode_select, as they're the only ones with union in the struct ?
Manuel Bouyer, LIP6, Universite Paris VI. Manuel.Bouyer@lip6.fr