Subject: Re: i386 make GENERIC kernel failure
To: Ken Wellsch <kwellsch@tampabay.rr.com>
From: Andrew Doran <ad@netbsd.org>
List: current-users
Date: 02/06/2001 15:40:42
Ken Wellsch <kwellsch@tampabay.rr.com> wrote:
> After doing a cvs update an hour or so ago (i.e. current -current) I
> see this when I try to build a GENERIC kernel:
> 
> cc  -O2 -Werror -Wall -Wmissing-prototypes -Wstrict-prototypes 
> -Wpointer-arith -Wno-uninitialized -Wno-main -I. -I../../../../arch
> -I../../../.. -nostdinc -DLKM -DDIAGNOSTIC -DMAXUSERS=32 -D_KERNEL -Di386  -c
> ../../../../dev/i2o/ld_iop.c
> cc1: warnings being treated as errors
> ../../../../dev/i2o/ld_iop.c: In function `ld_iop_detach':
> ../../../../dev/i2o/ld_iop.c:339: warning: implicit declaration of function
> `lddrain'
> ../../../../dev/i2o/ld_iop.c:352: warning: implicit declaration of function
> `lddetach'
> *** Error code 1
> 
> Stop.

Already fixed  - here's a patch:

Index: ld_iop.c
===================================================================
RCS file: /cvsroot/syssrc/sys/dev/i2o/ld_iop.c,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- ld_iop.c	2001/01/03 21:01:29	1.4
+++ ld_iop.c	2001/02/06 12:22:24	1.5
@@ -1,4 +1,4 @@
-/*	$NetBSD: ld_iop.c,v 1.4 2001/01/03 21:01:29 ad Exp $	*/
+/*	$NetBSD: ld_iop.c,v 1.5 2001/02/06 12:22:24 ad Exp $	*/
 
 /*-
  * Copyright (c) 2000 The NetBSD Foundation, Inc.
@@ -336,7 +336,7 @@
 
 	sc = (struct ld_iop_softc *)self;
 
-	if ((rv = lddrain(&sc->sc_ld, flags)) != 0)
+	if ((rv = ldbegindetach(&sc->sc_ld, flags)) != 0)
 		return (rv);
 
 	iop = (struct iop_softc *)self->dv_parent;
@@ -349,7 +349,7 @@
 		iop_util_abort(iop, &sc->sc_ii, 0, 0,
 		    I2O_UTIL_ABORT_WILD | I2O_UTIL_ABORT_CLEAN);
 
-	lddetach(&sc->sc_ld);
+	ldenddetach(&sc->sc_ld);
 
 	/* Un-claim the target, and un-register us as an initiator. */
 	if ((sc->sc_ld.sc_flags & LDF_ENABLED) != 0) {