On Thu, 10 Aug 2000, Geoff Wing wrote:

> :	if_arp.c:
> :	    Sounds useful enough to include in a PR?
> 
> Probably not.  I was getting lots of ``arpresolve: can't allocate llinfo''
> errors and I just wanted to find out where they were coming from so I just
> hacked in some debugging information (*).
> 
> It turned out packets somehow got through from a 192.168.* network and I'd
> also done a ``route add -reject 192.168.0.0 -netmask 255.255.0.0 127.0.0.1''
> on my machine so I guess that's why.  Possibly I should just use -blackhole
> instead of -reject.
> 
> (*) Just for reference (I haven't checked its thoroughness w.r.t. dst):
> --- src/sys/netinet/if_arp.c	Wed May 24 20:36:14 2000
> +++ /obj/src/sys/netinet/if_arp.c	Tue Aug  1 13:47:53 2000
> @@ -592,7 +592,7 @@
>  			rt = la->la_rt;
>  	}
>  	if (la == 0 || rt == 0) {
> -		log(LOG_DEBUG, "arpresolve: can't allocate llinfo\n");
> +		log(LOG_DEBUG, "arpresolve: can't allocate llinfo: %s\n", in_fmtaddr(SIN(dst)->sin_addr));
>  		m_freem(m);
>  		return (0);
>  	}

	I don't know about anyone else - but to me that looks like extra
	information that can be useful to someone trying to work out what
	is happening. If you want to run that check on its use of dst,
	then I'd definitely submit it as a PR :)
	

                David/absolute
			       -- www.netbsd.org: A pmap for every occasion --