Subject: Re: failure on building fstat
To: Paul Hoffman <firstname.lastname@example.org>
From: Bill Sommerfeld <email@example.com>
Date: 05/27/2000 23:00:21
> I sup'd this afternoon. Building the kernel went fine. "make build" died with:
> fstat.c: In function `dofiles':
> fstat.c:351: warning: passing arg 1 of `vtrans' from incompatible pointer type
> *** Error code 1
Caught and fixed this afternoon; should be available in tomorrow's
sup. Sorry for the hiccup, this was my error.
Interestingly enough, the <sys/proc.h> change that triggered this
compile error actually caught a bug in fstat which existed ever since
ktruss/sys_fktrace was added to the system; ktrace assumed that
proc->p_tracep always pointed at a vnode. When fktrace was added,
p_tracep was modified to point at either a file or a vnode, but fstat
wasn't modified to match.
Now, p_tracep always points at a "struct file", and fstat has been
fixed to be aware of this.