Subject: Undeclared BUFQ_INSERT_HEAD in pmax and amiga kernels
To: None <current-users@netbsd.org, port-pmax@netbsd.org>
From: NetBSD Mailing list <netbsd@mrynet.com>
List: current-users
Date: 01/23/2000 13:54:32
The following occurs in the pmax port when building the GENERIC kernel:

	cc  -O2 -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes  -Wpointer-arith -Wno-main -G 0  -mno-abicalls -mno-half-pic -I. -I/usr/src/sys/arch -I/usr/src/sys -nostdinc -I/usr/src/sys/../gnu/sys -DMIPS1 -DMIPS3 -DLKM -DNKMEMCLUSTERS=1024 -DHZ=256 -DMAXUSERS=64 -D_KERNEL -Dpmax  -c /usr/src/sys/arch/pmax/dev/tz.c
	cc1: warnings being treated as errors
	/usr/src/sys/arch/pmax/dev/tz.c: In function `tzprobe':
	/usr/src/sys/arch/pmax/dev/tz.c:231: warning: implicit declaration of function `BUFQ_INSERT_HEAD'
	*** Error code 1

A search of the source tree indicates the following:

	mrynet# find . -type f -exec grep -n BUFQ_INSERT_HEAD \{\} \; -print
	1252:           BUFQ_INSERT_HEAD(&sc->bufq, bp);
	./sys/arch/amiga/dev/fd.c
	285:            BUFQ_INSERT_HEAD(&sc->sc_tab, &sc->sc_buf);
	332:                    BUFQ_INSERT_HEAD(&sc->sc_tab, &sc->sc_buf);
	388:    BUFQ_INSERT_HEAD(&sc->sc_tab, &sc->sc_buf);
	453:    BUFQ_INSERT_HEAD(&sc->sc_tab, &sc->sc_buf);
	868:                    BUFQ_INSERT_HEAD(&sc->sc_tab, &sc->sc_errbuf);
	1401:   BUFQ_INSERT_HEAD(&sc->sc_tab, &sc->sc_buf);
	1734:           BUFQ_INSERT_HEAD(&sc->sc_tab, &sc->sc_buf);
	./sys/arch/pmax/dev/rz.c
	231:    BUFQ_INSERT_HEAD(&sc->sc_tab, &sc->sc_buf);
	246:    BUFQ_INSERT_HEAD(&sc->sc_tab, &sc->sc_buf);
	357:    BUFQ_INSERT_HEAD(&sc->sc_tab, &sc->sc_buf);
	598:                    BUFQ_INSERT_HEAD(&sc->sc_tab, &sc->sc_errbuf);
	./sys/arch/pmax/dev/tz.c

The lack of a declaration anywhere suggests that the amiga port would be 
exhibiting the same failure with fd.c.

-skots
--
Scott G. Akmentins-Taylor     InterNet: staylor@mrynet.com
MRY Systems			        staylor@mrynet.lv
    (Skots Gregorijs Akmentins-Teilors -- just call me "Skots")
		----- Labak miris neka sarkans -----