hi,

I'm setting MASTER_SITE_OVERRIDE in my /etc/mk.conf to first try to
fetch packages from a german mirror. since some days now i get an
error:

make fetch
Variable PATCH_SITES is recursive.
*** Error code 2

Stop.
*** Error code 1

Stop.

this comes from lines 622 to 628 of /usr/pkgsrc/mk/bsd.pkg.mk

.if !defined(MASTER_SITE_OVERRIDE)
MASTER_SITES+=  ${MASTER_SITE_BACKUP}
PATCH_SITES+=   ${MASTER_SITE_BACKUP}
.else
MASTER_SITES:=  ${MASTER_SITE_OVERRIDE} ${MASTER_SITES}
PATCH_SITES:=   ${MASTER_SITE_OVERRIDE} ${PATCH_SITES}
.endif

reason is, that PATCH_SITES isn't initialised in the else case
(MASTER_SITES is initialized by the package Makefile).

since PATCH_SITES may be initialized by the package Makefile, too,
the else case should read:

.else
PATCH_SITES?=
MASTER_SITES:=  ${MASTER_SITE_OVERRIDE} ${MASTER_SITES}
PATCH_SITES:=   ${MASTER_SITE_OVERRIDE} ${PATCH_SITES}
.endif

I've testet my patch w/ /usr/pkgsrc/x11/kdelibs and it seems to be ok.

-ks