Subject: Re: Mozilla diffs
To: Simon Burge <simonb@telstra.com.au>
From: Simon J. Gerraty <sjg@quick.com.au>
List: current-users
Date: 04/02/1998 13:05:40
Simon Burge writes:
>On Thu, 2 Apr 1998 03:38:55 +0200 (MET DST)  Frank van der Linden wrote:
>> I did a bit of work getting Mozilla to compile on -current. The first result
>> is in pub/NetBSD/misc/fvdl/mozilla.diff on ftp.netbsd.org

Thanks Frank I'll grab them.

>> Some notes:
>> 
>> 	* When linked with Lesstiff, it dumps core when trying to load
>> 	  the first page. When linked with a 'real' Motif library,
>> 	  it works. So unless you have Motif or are willing to debug
>> 	  this, the diff might not be of much use to you at the moment.
>> 	  Lesstiff will print out some warning messages possibly
>> 	  related to ifndef MOTIF11 in cmd/xfe/Microline3.0/XmL/Grid.c,
>> 	  which might be related to the crash.

What version of Lesstif?  There was a patch posted to the lesstif list
yesterday? To fix core dumps in 0.83 with Mozilla.  I'll dig it up if you
like.  Here it is:

>From: Dan McGuirk <mcguirk@indirect.com>

This patch to Lesstif 0.83 fixes some crashes with Mozilla.  The original
code seems to be in error--the function is being passed a pointer to the
pointer it wants to free, not the pointer itself.

I think my build always crashed on the second page I tried to view before
I made this patch.

Index: lib/Xm/FontList.c
pointer it wants to free, not the pointer itself.

I think my build always crashed on the second page I tried to view before
I made this patch.

Index: lib/Xm/FontList.c
===================================================================
RCS file: /usr/local/cvsroot/lesstif/lib/Xm/FontList.c,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 FontList.c
--- FontList.c  1998/03/31 21:39:14     1.1.1.1
+++ FontList.c  1998/04/01 00:54:55
@@ -211,7 +211,7 @@
     if (entry)
     {
        XtFree((*entry)->tag);
-       XtFree((XtPointer)entry);
+       XtFree((XtPointer)*entry);
 
        /* should we close the Font? */
     }


>> In other words: this is a diff for the brave, and more to let you know
>> that this is being worked on..

Cool. Thanks.

>I took your diffs from about 24 hours ago, and have almost got the
>mozilla linking on the pmax (I think I've got a c++ problem that was
>reported on the pmax lists).  I'm building against 1.3 (1.3.1 as of
>today).  Do you want my diffs against yours when (if?) I get it at least
>linking?

Yes please.  The MCG (Mozilla Crypto Group) are announcing (right now) the 
availability the first cryptozilla binaries (for Linux) and I'd like 
to be able to get NetBSD onto the supported list asap.

See http://mozilla-crypto.ssleay.org/

--sjg