Subject: Re: Problem in mac68k -current
To: Paul Goyette <paul@whooppee.com>
From: Jason Thorpe <thorpej@nas.nasa.gov>
List: current-users
Date: 05/25/1997 14:51:12
On Sun, 25 May 1997 14:42:37 -0700 (PDT)
Paul Goyette <paul@whooppee.com> wrote:
> Seems to me that the grf_mv.c version should look more like:
>
> gm->fbbase = (caddr_t) mac68ktrunk_page(sc->sc_handle + image.offset);
> gm->fboff = (sc->sc_handle + image.offset)& PGOFSET;
>
> What do you think?
...I think you are probably correct! However, don't forget the "XXX evil!"
comments... as Scott and I have discussed before, there's not much you
can do about it, but you're using a bus_space_handle_t as an address
there.. (which is "ok" since this is not MI code :-)
(err, oh yah... that sould be mac68k_trunc_page(), not trunk :-)
Jason R. Thorpe thorpej@nas.nasa.gov
NASA Ames Research Center Home: 408.866.1912
NAS: M/S 258-6 Work: 415.604.0935
Moffett Field, CA 94035 Pager: 415.428.6939