Subject: Re: NetBSD master CVS tree commits
To: None <current-users@NetBSD.ORG>
From: Guenther Grau <s_grau@ira.uka.de>
List: current-users
Date: 01/23/1997 15:41:31
Hi,

> >Log Message:
> >inet_makeaddr() takes unsigned long, not int, arguments; fixes PR lib/2385.
> 
> Not according to solaris-2.5.1:
> 
> struct in_addr inet_makeaddr(const int net, const int lna);
> 
> maybe 'const in_addr_t' is more correct?

Why should it be made const?

And while I agree that the paramters are int in solaris I find this inconsistent,
because when I quote the two lines above (man) inet_makeaddr:

     unsigned long inet_addr(const char *cp);

     unsigned long inet_network(const char *cp);

     struct in_addr inet_makeaddr(const int net, const int lna);

inet_addr and inet_network return unsigned long, and inet_makeaddr
takes const int as parameters. You even might have to cast it if
you are on the Alpha :-/

  Guenther