Subject: Re: NetBSD master CVS tree commits
To: None <tls@NetBSD.ORG>
From: Chris G. Demetriou <cgd@CS.cmu.edu>
List: current-users
Date: 01/14/1997 16:13:25
> tls
> Thu Jan  9 02:27:00 PST 1997
> Update of /a/cvsroot/src/domestic/usr.bin/passwd
> In directory netbsd1:/var/slash-tmp/cvs-serv15250/passwd
> 
> Modified Files:
> 	Makefile 
> Log Message:
> use AFS string to key function if AFS is defined

Two comments:

	(1) using the global definition of 'AFS' in the Makefiles
	    isn't necessarily such a good idea, since it's such a
	    short identifier and it can be easily 'tripped' over.

	(2) including a seperate library based on this is arguably
	    a bad idea, too.  it means that people who want to use
	    the AFS string-to-key routine need to recompile the
	    binaries to use them.


The latter's not necessarily such a problem (it's not _so_ big a cost,
but it could be annying), but the former could be a problem.  System
makefile namespace management is "important."


chris