Subject: Re: Samba core dumps.
To: Matthias Scheler <tron@lyssa.owl.de>
From: David Gilbert <dgilbert@jaywon.pci.on.ca>
List: current-users
Date: 09/28/1996 23:24:10
>>>>> "Matthias" == Matthias Scheler <tron@lyssa.owl.de> writes:

Matthias> David Gilbert said:
>> Yeah... I know... if I'm using Samba, then I must be using
>> <censored>.  Anyways... when I run nmbd, I get a core dump.

Matthias> Which version? 1.9.16p2 works fine for me.

	That's the version I'm using.  I've included my patch.  I
havn't looked to see why this ends up here, but a) NetBSD doesn't seem
to allow you to fclose(NULL) and b) I'm using samba slightly
differently such that it tries to do this.

	Now... if you look at the code above this patch, there is a
section of code protected against f == NULL, but fclose(NULL) must
work for some systems... not that this knowledge would make me ever
pass a NULL to fclose(), but still...

*** namedbname.c~       Wed Aug 21 04:34:13 1996
--- namedbname.c        Sat Sep 28 23:14:54 1996
***************
*** 262,269 ****
        }
  
      }
! 
!   fclose(f);
    unlink(fname);
    chmod(fnamenew,0644);
    rename(fnamenew,fname);   
--- 262,270 ----
        }
  
      }
!   
!   if(f)
!       fclose(f);
    unlink(fname);
    chmod(fnamenew,0644);
    rename(fnamenew,fname);   

Dave.

-- 
============================================================================
|David Gilbert, PCI, Richmond Hill, Ontario.  | Two things can only be     |
|Mail:      dgilbert@jaywon.pci.on.ca         |  equal if and only if they |
|http://www.pci.on.ca/~dgilbert               |   are precisely opposite.  |
=========================================================GLO================