Subject: build errors / warnings with SETUIDSCRIPTS set
To: None <current-users@NetBSD.ORG>
From: Jon Buller <jonb@metronet.com>
List: current-users
Date: 08/27/1996 21:12:52
I tried building a kernel with this line in my config file:

options         SETUIDSCRIPTS   # allow scripts to run set-uid

and got this as a result:

cc  -O2 -Werror -Wall -Wstrict-prototypes -Wmissing-prototypes -mno-fpu -I. -I../../../../arch -I../../../.. -DSUN4C -DSWAPPAGER -DVNODEPAGER -DDEVPAGER -DKTRACE -DSYSVMSG -DSYSVSEM -DSYSVSHM -DLKM -DSETUIDSCRIPTS -DCOMPAT_43 -DCOMPAT_10 -DCOMPAT_11 -DCOMPAT_SUNOS -DCOMPAT_SVR4 -DFFS -DQUOTA -DNFSSERVER -DNFSCLIENT -DKERNFS -DNULLFS -DMFS -DFDESC -DUMAPFS -DLFS -DPORTAL -DPROCFS -DCD9660 -DUNION -DFIFO -DINET -DPPP_BSDCOMP -DPPP_DEFLATE -DRASTERCONSOLE -D_KERNEL  -c ../../../../kern/exec_script.c
cc1: warnings being treated as errors
../../../../kern/exec_script.c: In function `exec_script_makecmds':
../../../../kern/exec_script.c:175: warning: suggest parentheses around assignment used as truth value
../../../../kern/exec_script.c:71: warning: `shellargp' might be used uninitialized in this function
../../../../kern/exec_script.c:72: warning: `scriptvp' might be used uninitialized in this function
../../../../kern/exec_script.c:74: warning: `script_uid' might be used uninitialized in this function
../../../../kern/exec_script.c:75: warning: `script_gid' might be used uninitialized in this function
../../../../kern/exec_script.c:230: warning: `vp' might be used uninitialized in this function
*** Error code 1

Stop.


I "fixed" this by removing "-Werror" from the makefile (cause I'm
lazy) but thought someone might want to properly fix it for the
impending release, or perhaps just for some point in the future.
I'd look into it more, but I'm already way behind on getting st(4)
in for review and a commit...  (Sorry Michael.)

Jon Buller