Subject: Libkern does not use the same includes as the kernel sources
To: None <current-users@sun-lamp.cs.berkeley.edu>
From: Eduardo E. Horvath eeh@btr.com <eeh@btr.btr.com>
List: current-users
Date: 05/16/1994 22:25:53
I was building a new kernel and discovered that CFLAGS are not passed on
when the kernel build fires up the libkern makefile. This means that
while the kernel is built using /src/sys/sys include files, libkern is
build with /usr/include/sys. This could cause problems when upgrading to
a major change, such as a /usr/include with a 32-bit off_t and a
/src/sys/sys with a 64-bit off_t.
Here is my proposed enhancement to make libkern consistent with the rest
of the kernel:
*** src/sys/lib/libkern/Makefile.inc~ Mon May 16 20:40:35 1994
--- src/sys/lib/libkern/Makefile.inc Mon May 16 20:40:17 1994
***************
*** 12,21 ****
$(KERNLIB): .NOTMAIN __always_make_kernlib
@echo making sure the kern library is up to date...
! @(cd $(KERNDIR) ; $(MAKE))
$(KERNLIB_PROF): .NOTMAIN __always_make_kernlib
@echo making sure the profiled kern library is up to date...
! @(cd $(KERNDIR) ; $(MAKE))
__always_make_kernlib: .NOTMAIN
--- 12,21 ----
$(KERNLIB): .NOTMAIN __always_make_kernlib
@echo making sure the kern library is up to date...
! @(cd $(KERNDIR) ; $(MAKE) "CFLAGS=$(CFLAGS)")
$(KERNLIB_PROF): .NOTMAIN __always_make_kernlib
@echo making sure the profiled kern library is up to date...
! @(cd $(KERNDIR) ; $(MAKE) "CFLAGS=$(CFLAGS)")
__always_make_kernlib: .NOTMAIN
=========================================================================
Eduardo Horvath eeh@btr.com
..!{decwrl,mips,fernwood}!btr!eeh
"Trust me, I am cognizant of what I am doing." - Hammeroid
------------------------------------------------------------------------------