New Defects reported by Coverity Scan for NetBSD-i386-kernel

[scan-admin%coverity.com@localhost]

Hi,

Please find the latest report on new defect(s) introduced to NetBSD-i386-kernel found with Coverity Scan.

2 new defect(s) introduced to NetBSD-i386-kernel found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1324963:  Null pointer dereferences  (REVERSE_INULL)
/sys/dev/acpi/valz_acpi.c: 428 in hci_op()


________________________________________________________________________________________________________
*** CID 1324963:  Null pointer dereferences  (REVERSE_INULL)
/sys/dev/acpi/valz_acpi.c: 428 in hci_op()
422     	for (i = 0; i < HCI_WORDS; i++) {
423     		if (PrtElement->Type == ACPI_TYPE_INTEGER)
424     			output[i] = PrtElement->Integer.Value;
425     			PrtElement++;
426     	}
427     
>>>     CID 1324963:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "buf.Pointer" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
428     	if (buf.Pointer)
429     		ACPI_FREE(buf.Pointer);
430     
431     	return rv;
432     }
433     

** CID 1324962:  Control flow issues  (NESTING_INDENT_MISMATCH)
/sys/dev/acpi/valz_acpi.c: 425 in hci_op()


________________________________________________________________________________________________________
*** CID 1324962:  Control flow issues  (NESTING_INDENT_MISMATCH)
/sys/dev/acpi/valz_acpi.c: 425 in hci_op()
419     	}
420     	param = (ACPI_OBJECT *)buf.Pointer;
421     	PrtElement = param->Package.Elements;
422     	for (i = 0; i < HCI_WORDS; i++) {
423     		if (PrtElement->Type == ACPI_TYPE_INTEGER)
424     			output[i] = PrtElement->Integer.Value;
>>>     CID 1324962:  Control flow issues  (NESTING_INDENT_MISMATCH)
>>>     This  statement is indented to column 25, as if it were nested within the preceding parent statement, but it is not.
425     			PrtElement++;
426     	}
427     
428     	if (buf.Pointer)
429     		ACPI_FREE(buf.Pointer);
430     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/netbsd-i386-kernel?tab=overview

To manage Coverity Scan email notifications for "coverity-updates%netbsd.org@localhost", click https://scan.coverity.com/subscriptions/edit?email=coverity-updates%40netbsd.org&token=487286ca1a9a4f4bd485d16f66b5e782