Subject: vbl handler in grfabs_cc.c
To: None <amiga-dev@sun-lamp.cs.berkeley.edu>
From: Francis Demierre <francis@hasler.ascom.ch>
List: amiga-dev
Date: 03/14/1994 13:28:35
Hi All,

just a quick question:

in amiga/dev/grfabs_cc.c (Sup'ed from sunlamp on 14th Mar):
-----------------------------------------------------------

void
cc_mode_vbl_handler(d)
        dmode_t *d;
{
   u_short vp = ((custom.vposr & 0x0007) << 8) | ((custom.vhposr) >> 8);

   if (vp < 12) {
       custom.cop1lc = PREP_DMA_MEM(h_this_data->frames[F_LONG]);
                                        ^
                                        |
LOOK HERE - USES -----------------------+
################

       custom.copjmp1 = 0;
   }
}

void
cc_lace_mode_vbl_handler(d)
        dmode_t *d;
{
   u_short vp = ((custom.vposr & 0x0007) << 8) | ((custom.vhposr) >> 8);

   if (vp < 12) {
       if (custom.vposr & 0x8000) {
           custom.cop1lc = PREP_DMA_MEM(DMDATA(d)->frames[F_LACE_LONG]);
       } else {
           custom.cop1lc = PREP_DMA_MEM(DMDATA(d)->frames[F_LACE_SHORT]);
       }
       custom.copjmp1 = 0;
   }
}


And Later (under #ifdef GRF_PAL) in the routine cc_init_pal_hires():

...
 ph_this_data->vbl_handler = (vbl_handler_func *) cc_mode_vbl_handler;
...

So, the installed cc_mode_vbl_handler will try to use 'h_this_data' 
instead of 'ph_this_data' ! Shouldn't cc_mode_vbl_handler() also use 
something like  

   custom.cop1lc = PREP_DMA_MEM(DMDATA(d)->frames[F_LONG]);




And as a side question: Is it possible to compile the kernel without 
GRF_NTSC ?  (I tried with  the above modification) and all I get is a 
Dark screen at start  of boot and the system does not seem to proceed 
with booting.

Thanks and have a nice day ....
Francis


-----------------------------------------------------------------------
Francis Demierre          SMTP : francis@hasler.ascom.ch
Ascom Hasler AG,          UUCP: ...!mcsun!chsun!hslrswi!francis
Abt. NVEI2,               X.400: S=francis/O=ascom/P=eunet/A=arcom/C=ch
Belpstrasse 37,,          Tel. : +41 31 999 3503
CH-3000 Bern 14           Fax  : +41 31 999 3735
-----------------------------------------------------------------------

------------------------------------------------------------------------------