tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[PATCH] don't call pkg_create with -U (unused)



Any reason not to commit this? the code suggests it isn't used.
create/main.c

/* -U is silently ignored, it used to inhibit pkgdb changes. */
...
        while ((ch = getopt(argc, argv, Options)) != -1)
                switch (ch) {
...
                case 'U':
                        break;

pkg_create -U is a no-op. Document this, and don't use it.

Index: pkgtools/pkg_install/files/create/pkg_create.1
===================================================================
RCS file: /cvsroot/pkgsrc/pkgtools/pkg_install/files/create/pkg_create.1,v
retrieving revision 1.27
diff -u -r1.27 pkg_create.1
--- pkgtools/pkg_install/files/create/pkg_create.1	10 Apr 2016 19:01:19 -0000	1.27
+++ pkgtools/pkg_install/files/create/pkg_create.1	15 May 2020 12:17:28 -0000
@@ -24,7 +24,7 @@
 .\" [jkh] Took John's changes back and made some additional extensions for
 .\" better integration with FreeBSD's new ports collection.
 .\"
-.Dd December 27, 2014
+.Dd May 15, 2020
 .Dt PKG_CREATE 1
 .Os
 .Sh NAME
@@ -247,6 +247,8 @@
 Make
 .Ar owner
 the default owner instead of extracting it from the file system.
+.It Fl U
+has no effect.
 .It Fl V
 Print version number and exit.
 .It Fl v
Index: mk/pkgformat/pkg/metadata.mk
===================================================================
RCS file: /cvsroot/pkgsrc/mk/pkgformat/pkg/metadata.mk,v
retrieving revision 1.23
diff -u -r1.23 metadata.mk
--- mk/pkgformat/pkg/metadata.mk	30 Apr 2020 23:50:28 -0000	1.23
+++ mk/pkgformat/pkg/metadata.mk	15 May 2020 12:19:25 -0000
@@ -399,7 +399,7 @@
 	${AWK} '$$1 == "bootstrap" || $$1 == "build" { printf "@blddep %s\n", $$3; }' < ${_RDEPENDS_FILE}; \
 	${CAT} ${PLIST}; } > ${.TARGET}
 
-_PKG_CREATE_ARGS+=				-l -U
+_PKG_CREATE_ARGS+=				-l
 _PKG_CREATE_ARGS+=				-B ${_BUILD_INFO_FILE}
 _PKG_CREATE_ARGS+=				-b ${_BUILD_VERSION_FILE}
 _PKG_CREATE_ARGS+=				-c ${_COMMENT_FILE}


Home | Main Index | Thread Index | Old Index