On Mon, 28 Nov 2005, Roland Illig wrote:
>> -# Some paths for output files and paths to log files
>> -FTPx=`date +%Y%m%d.%H%M`
>> -FTPURL="pub/NetBSD/pkgstat/${FTPx}"            # relative to ~ftp !
>> -FTP="/home/ftp/${FTPURL}"                      # absolute base path
>> -FTPHOST="ftp://ftp.machi.ne"                   # host for broken.html
>> +# REPORT_DIR is the directory on the build machine where the
>> +# report files are copied to. Uploading these files to a public FTP or
>> +# HTTP server must be done manually. REPORT_URL is the URL where the
>> +# report files will be reachable after uploading. This URL is only used
>> +# for being printed in the text/plain report. bc_common_path is a helper
>> +# variable and is not examined by the bulk build programs.
>> +bc_common_path="`date +%Y%m%d.%H%M`"
>> +REPORT_DIR="$HOME/bulk-reports/${bc_common_path}"
>> +REPORT_URL="ftp://my.ftp.server.local/pub/NetBSD/pkgstat/${bc_common_path}" 
>> ----snip----

if you have to shuffle things around, I'd suggest making it clear that 
"bc_common_path" is the comon dir relative to the base directory in the 
filesystem in one case and relative to the base URL in another case.

As such, maybe something like:

FTPURL	=> REPORT_COMMON_DIR
FTP	=> REPORT_BASE_DIR
FTPHOST	=> REPORT_BASE_URL


>> Is it correct that using REPORT_URL="${FTPHOST}/${FTPURL}" and 
>> REPORT_DIR="${FTP}" would provide the needed backwards compatibility, or 
>> have I overseen anything?

That completely depends on what you do with REPORT_URL and REPORT_DIR.
I cannot comment on that part by your mail.


>> -REPORT="$FTP/broken.html"
>> ----snip----
>> 
>> I think this variable should be placed into bsd.pkg-bulk.mk into the 
>> section where the other variables for files in ${BULKFILESDIR} live. The 
>> report should be generated in that directory, too, and only later be copied 
>> to the REPORT_DIR, together with all the other files.

I guess that raises the question how hard we want to make it for users to 
change the report's name. Personally, I don't care.


  - Hubert