tech-net archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: ip_flow.c ipf struct member ipf_start



On Tue, Jan 17, 2012 at 05:15:02PM +0000, Liam J. Foy wrote:
> hi,
> 
> i appreciate this is only a minor nit. however...
> 
> ip_flow.c contains the struct ipf which in turn contains a member
> called ipf_start. this member is never used (only assigned, never
> read) and I can't see a time it ever was. i was going to remove it but
> another developer pointed out it might have been used for debugging
> but no one knows.
> 
> i propose to remove it completely or #ifdef the member.

I think that if nobody chimes in soon with a use for it, you should
delete it.

Please, whatever you do, don't #ifdef it!

Dave

-- 
David Young
dyoung%pobox.com@localhost    Urbana, IL    (217) 721-9981


Home | Main Index | Thread Index | Old Index