Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/dkwedge



On Sun, Jun 01, 2008 at 01:26:10PM +0100, Andrew Doran wrote:

> On Sun, Jun 01, 2008 at 11:38:27AM +0000, Chris Gilbert wrote:
> 
> > Module Name:        src
> > Committed By:       chris
> > Date:               Sun Jun  1 11:38:27 UTC 2008
> > 
> > Modified Files:
> >     src/sys/dev/dkwedge: dk.c
> > 
> > Log Message:
> > Call buf_destroy when finished with an on-stack struct buf.
> > 
> > Spotted by LOCKDEBUG, because the condvars were already initialised.
> 
> If the LWP is swapped out before the I/O completes, bad things will happen
> there. I guess it should use getiobuf() instead - I'll take a look.

Can someone try this easily?

http://www.netbsd.org/~ad/dk.diff

Andrew



Home | Main Index | Thread Index | Old Index