Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.bin/stat



Am 14.03.2024 um 20:38 schrieb Robert Elz:
> Module Name:	src
> Committed By:	kre
> Date:		Thu Mar 14 19:38:56 UTC 2024
>
> Modified Files:
> 	src/usr.bin/stat: stat.c
>
> Log Message:
> While the change in 1.51 certainly retained binary compat with
> what was in 1.50 (while silencing LINT) - it was clearly not the
> correct change to make.   The code used !FLAG_POUND where it
> clearly meant ~FLAG_POUND ... the former is 0, so &= 0 could
> be replaced by =0 changing nothing.   But that's not what it
> should have been doing, other flags should not have been
> removed here, just FLAG_POUND.

I don't think the flags '+' and '0' make sense for strings, that's why I
decided to preserve existing behavior.

Roland



Home | Main Index | Thread Index | Old Index