Re: CVS commit: src/sys

[Taylor R Campbell <riastradh%NetBSD.org@localhost>]

> Date: Tue, 10 Oct 2023 18:58:29 +0000
> From: Andrew Doran <ad%netbsd.org@localhost>
> 
> On Tue, Oct 10, 2023 at 06:00:57PM +0200, J. Hannken-Illjes wrote:
> 
> > > cvs rdiff -u -r1.63 -r1.64 src/sys/kern/sys_select.c
> > 
> > -    sleepq_unsleep(l, false);
> > +    sleepq_remove(l->l_sleepq, l, true);
> >     }
> >    }
> >    mutex_spin_exit(lock);
> > 
> > Looks like sleepq_remove() unlocks l->l_mutex == lock and
> > then mutex_spin_exit(lock) will unlock an unlocked mutex.
> [...]
> Did you encounter a problem?

Yes, this appears to be breaking hundreds of automatic tests, which is
getting in the way of all kernel testing.

https://mail-index.netbsd.org/current-users/2023/10/13/msg044522.html
https://mail-index.netbsd.org/current-users/2023/10/13/msg044523.html
https://mail-index.netbsd.org/current-users/2023/10/13/msg044524.html

Enough breakage has happened over several days that bracket is unable
to discern which changes have broken which tests now:

https://mail-index.netbsd.org/current-users/2023/10/13/msg044525.html
https://mail-index.netbsd.org/current-users/2023/10/13/msg044526.html

Please fix immediately or back out.